linux-kernel - Re: [PATCH 1/6] compacting file_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070720112409.GB6300@mail.ustc.edu.cn>
Date:	Fri, 20 Jul 2007 19:24:09 +0800
From:	Fengguang Wu <wfg@...l.ustc.edu.cn>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Andrew Morton <akpm@...l.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] compacting file_ra_state

On Fri, Jul 20, 2007 at 12:48:59PM +0200, Peter Zijlstra wrote:
> On Fri, 2007-07-20 at 12:26 +0200, Peter Zijlstra wrote:
> > On Fri, 2007-07-20 at 18:07 +0800, Fengguang Wu wrote:
> > > plain text document attachment (short-rasize.patch)
> > > Use 'unsigned int' instead of 'unsigned long' for the readahead indexes/sizes.
> > > 
> > > This helps reduce memory consumption on 64bit CPU when
> > > a lot of files are opened.
> > > 
> > > Note that the (smaller) 32bit index can support up to 16PB file.
> > > Which should be sufficient large at least for now.
> > 
> > Perhaps merge prev_offset and prev_index into a pgoff_t prev? That
> > should give the same savings on 64bit and be more correct on 32bit.
> 
> s/pgoff_t/loff_t/

Good idea!                                                                                                              
This could solve Andi's concern as well :)                                                                              
                                                                                                                        
I'm coding it up, and sure it'll need some more tests...                                                                

> (and how come lkml was not on the CC list?)

:) 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/