lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070720150627.GA12822@suse.de>
Date:	Fri, 20 Jul 2007 08:06:27 -0700
From:	Greg KH <gregkh@...e.de>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	Gabriel C <nix.or.die@...glemail.com>,
	Robert Schwebel <r.schwebel@...gutronix.de>,
	Jan Engelhardt <jengelh@...putergmbh.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kay.sievers@...y.org
Subject: Re: kobject link failure

On Fri, Jul 20, 2007 at 01:58:13PM +0200, Cornelia Huck wrote:
> On Fri, 20 Jul 2007 11:32:21 +0200,
> Cornelia Huck <cornelia.huck@...ibm.com> wrote:
> 
> > Hm, this would be an interface change (the uevent attribute used to
> > exist even for !CONFIG_HOTPLUG, it just triggered nothing). How about
> > moving kobject_actions[] out of the #ifdef (maybe next to
> > kobject_action)?
> 
> Leaving kobject_actions[] in kobject_uevent.c, but putting it outside
> the #ifdef looks indeed like the best solution to me. This way, we
> avoid adding #ifdef CONFIG_HOTPLUG into core.c, when all other
> functions called do not need such a thing.

Yeah, this is much nicer and smaller, thanks.  I'll throw away my patch
and use this one instead.

Can someone verify that it works properly for them please?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ