[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46A0F301.4020703@zytor.com>
Date: Fri, 20 Jul 2007 10:38:09 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Andi Kleen <ak@...e.de>
CC: "Luck, Tony" <tony.luck@...el.com>,
Randy Dunlap <randy.dunlap@...cle.com>,
Andi Kleen <ak@...ell.com>,
Arthur Jones <arthur.jones@...gic.com>,
Vasily Tarasov <vtaras@...nvz.org>,
linux-kernel@...r.kernel.org, Jan Kara <jack@....cz>,
linux-arch@...r.kernel.org
Subject: Re: build fix for x86_64...
Andi Kleen wrote:
>
> That doesn't help for any old interfaces, like the one here. For those
> still ifdefs are needed. Interfaces that use compat_u64 just use
> a normal #ifdef CONFIG_COMPAT.
>
> Besides I have my doubts compat_u64 will be the solution
> to these worries. We have hundreds of people adding various interfaces
> to Linux and it's unlikely they all heard about it. So likely
> these cases will occur again and again.
>
Of course they will. compat_u64 will have no effect on a properly
designed interface where everything is aligned.
To me, the whole point with compat_u64 is that when someone has designed
an interface improperly (so it's alignment-dependent) then we can
replace u64 with compat_u64 and use the same structure on 64 bits even
though the original interface was broken.
-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists