linux-kernel - Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070720180019.GJ14791@parisc-linux.org>
Date:	Fri, 20 Jul 2007 12:00:19 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Simon Arlott <simon@...e.lp0.eu>
Cc:	Denis Cheng <crquan@...il.com>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

On Fri, Jul 20, 2007 at 06:36:02PM +0100, Simon Arlott wrote:
> On 20/07/07 18:07, Matthew Wilcox wrote:
> > sed -i -e 's/^\t*      \(\w*:\)/ \1/' "$@"
> > 
> > which will replace the leading tabs and spaces with one space.
> 
> ... isn't the space thing a workaround for a "diff -p" bug?

Yes.  I like not being affected by bugs.  If you prefer to be affected
by bugs, that's up to you.

> Labels should either not have any indent or be indented by tabs (since
> some code could presumably benefit from indenting labels).

Indenting labels implies that they might be scoped with the other code
at that level of indentation.  If you see code that looks like this:

	for () {
		switch () {
		case foo:
			while () {
				if () {
				} else {
 quux:
 				}
			}
		}
	}

you really want the quux standing out at you.  Otherwise you might think
this was a nice, easy to understand function.

> Mass
> replacing any labels run through Lindent with space prefixes would seem
> like a bad idea :/

We don't tend to mass-run code through Lindent.  This may or may not be
a bad thing, but the fact is that it just doesn't happen.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/