linux-kernel - Re: [RFC][-mm PATCH 3/8] Memory controller accounting setup (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599ad830707201339u413d860co739dc301fb6c9405@mail.gmail.com>
Date:	Fri, 20 Jul 2007 13:39:58 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Balbir Singh" <balbir@...ux.vnet.ibm.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linux Containers" <containers@...ts.osdl.org>,
	"YAMAMOTO Takashi" <yamamoto@...inux.co.jp>,
	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	"Dave Hansen" <haveblue@...ibm.com>,
	"Linux MM Mailing List" <linux-mm@...ck.org>,
	"Vaidyanathan Srinivasan" <svaidy@...ux.vnet.ibm.com>,
	"Pavel Emelianov" <xemul@...nvz.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Eric W Biederman" <ebiederm@...ssion.com>
Subject: Re: [RFC][-mm PATCH 3/8] Memory controller accounting setup (v3)

On 7/20/07, Paul Menage <menage@...gle.com> wrote:
> On 7/20/07, Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> > +       mem = mem_container_from_cont(task_container(p,
> > +                                       mem_container_subsys_id));
> > +       css_get(&mem->css);
>
> The container framework won't try to free a subsystem's root container
> state, so this isn't needed.

Sorry, this was a reply to the wrong patch hunk.

The css_get() in mem_container_create() is the unnecessary one.

Also, rather than doing something like:

mem_container_from_cont(task_container(p, mem_container_subsys_id))

you'd be better off defining a similar wrapper to
mem_container_from_cont() called mem_container_from_task() that uses
task_subsys_state() rather than container_subsys_state() - you'll save
a few indirections.

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/