linux-kernel - [PATCH][cciss] Fix a small memory leak in the cciss driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200707202358.37140.jesper.juhl@gmail.com>
Date:	Fri, 20 Jul 2007 23:58:37 +0200
From:	Jesper Juhl <jesper.juhl@...il.com>
To:	Mike Miller <mike.miller@...com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	iss_storagedev@...com, Jesper Juhl <jesper.juhl@...il.com>
Subject: [PATCH][cciss] Fix a small memory leak in the cciss driver

Hello,

There's a memory leak in the cciss driver.

in alloc_cciss_hba() we may leak sizeof(ctlr_info_t) bytes if a 
call to alloc_disk(1 << NWD_SHIFT) fails.
This patch should fix the issue.

 Spotted by the Coverity checker.
 Compile tested only.


Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
---

 drivers/block/cciss.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index a2d6612..ef7ba22 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -3227,12 +3227,15 @@ static int alloc_cciss_hba(void)
 	for (i = 0; i < MAX_CTLR; i++) {
 		if (!hba[i]) {
 			ctlr_info_t *p;
+
 			p = kzalloc(sizeof(ctlr_info_t), GFP_KERNEL);
 			if (!p)
 				goto Enomem;
 			p->gendisk[0] = alloc_disk(1 << NWD_SHIFT);
-			if (!p->gendisk[0])
+			if (!p->gendisk[0]) {
+				kfree(p);
 				goto Enomem;
+			}
 			hba[i] = p;
 			return i;
 		}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/