linux-kernel - Re: build fix for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46A13859.7020608@zytor.com>
Date:	Fri, 20 Jul 2007 15:34:01 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Luck, Tony" <tony.luck@...el.com>
CC:	Andi Kleen <ak@...e.de>, Andreas Schwab <schwab@...e.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Arthur Jones <arthur.jones@...gic.com>,
	Vasily Tarasov <vtaras@...nvz.org>,
	linux-kernel@...r.kernel.org, Jan Kara <jack@....cz>,
	linux-arch@...r.kernel.org
Subject: Re: build fix for x86_64...

Luck, Tony wrote:
> At the moment our problem is that there is some code that has
> been added to handle the compatability problem caused by u64
> objects having different alignment when running on 32-bit and
> 64-bit systems.  This only affects ia64 and x86-64 because all
> the other 32/64 bit capable systems wisely avoided this issue
> by making 64-bit objects *always* 8-byte aligned.

> It is possible that in the future more such issues will arise
> (either because we find some more existing interfaces that
> have this problem, or because new interfaces are introduced
> that also have this problem).  Such new code will also require
> some compatability functions.  These functions will also only
> be needed on ia64 and x86-64, and even on these systems the
> code will only be needed if CONFIG_COMPAT=y

The issue here is I was looking at it from a new interfaces perspective,
and not from a legacy interfaces perspective.  However, for new
interfaces we want the opposite -- properly aligned elements -- so
please disregard previous objection.

However, I'm still thinking it might be worthwhile to consider the
__i[us]64 typedefs previously discussed as a way to avoid alignment
bloopers in new interfaces.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/