linux-kernel - Re: [PATCH 4/7] I/OAT: Split PCI startup from DMA handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070720105307.GB10631@pazke.donpac.ru>
Date:	Fri, 20 Jul 2007 14:53:08 +0400
From:	Andrey Panin <pazke@...pac.ru>
To:	Shannon Nelson <shannon.nelson@...el.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net, jeff@...zik.org, dan.j.williams@...el.com,
	christopher.leech@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [PATCH 4/7] I/OAT: Split PCI startup from DMA handling code

On 200, 07 19, 2007 at 05:45:07PM -0700, Shannon Nelson wrote:
> Split the general PCI startup from the DMA handling code in order to
> prepare for adding support for DCA services and future versions of the
> ioatdma device.
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@...el.com>
> ---
> 
>  drivers/dma/Makefile     |    2 
>  drivers/dma/ioat.c       |  186 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/dma/ioat_dma.c   |  196 +++++++++++-----------------------------------
>  drivers/dma/ioatdma.h    |   16 +++-
>  drivers/dma/ioatdma_hw.h |    2 
>  5 files changed, 245 insertions(+), 157 deletions(-)
> 
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index 77bee99..cec0c9c 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> @@ -1,5 +1,5 @@
>  obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
>  obj-$(CONFIG_NET_DMA) += iovlock.o
>  obj-$(CONFIG_INTEL_IOATDMA) += ioatdma.o
> -ioatdma-objs := ioat_dma.o
> +ioatdma-objs := ioat.o ioat_dma.o
>  obj-$(CONFIG_INTEL_IOP_ADMA) += iop-adma.o
> diff --git a/drivers/dma/ioat.c b/drivers/dma/ioat.c
> new file mode 100644
> index 0000000..9d9f672
> --- /dev/null
> +++ b/drivers/dma/ioat.c
> @@ -0,0 +1,186 @@
> +/*
> + * Intel I/OAT DMA Linux driver
> + * Copyright(c) 2004 - 2007 Intel Corporation.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
> + *
> + * The full GNU General Public License is included in this distribution in
> + * the file called "COPYING".
> + *
> + */
> +
> +/*
> + * This driver supports an Intel I/OAT DMA engine, which does asynchronous
> + * copy operations.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/module.h>
> +#include <linux/pci.h>
> +#include <linux/interrupt.h>
> +#include "ioatdma.h"
> +#include "ioatdma_registers.h"
> +#include "ioatdma_hw.h"
> +
> +MODULE_VERSION("1.24");
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Intel Corporation");
> +
> +static struct pci_device_id ioat_pci_tbl[] = {
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IOAT) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IOAT_CNB)  },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IOAT_SCNB) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_UNISYS, PCI_DEVICE_ID_UNISYS_DMA_DIRECTOR) },
> +	{ 0, }
> +};

Why this driver lacks MODULE_DEVICE_TABLE() ? Is it intentionaly omitted ?


-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@...pac.ru		| PGP key: wwwkeys.pgp.net

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)