linux-kernel - Re: [PATCH] Use descriptor's functions instead of inline assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A13F9C.6020107@didntduck.org>
Date:	Fri, 20 Jul 2007 19:05:00 -0400
From:	Brian Gerst <bgerst@...ntduck.org>
To:	Frederik Deweerdt <deweerdt@...e.fr>
CC:	Glauber de Oliveira Costa <gcosta@...hat.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, ak@...e.de
Subject: Re: [PATCH] Use descriptor's functions instead of inline assembly

Frederik Deweerdt wrote:
> On Fri, Jul 20, 2007 at 10:56:01AM -0300, Glauber de Oliveira Costa wrote:
>> This patch provides a new set of functions for managing the descriptor
>> tables that can be used instead of putting the raw assembly in .c files.
>>     
>> Signed-off-by: Glauber de Oliveira Costa <gcosta@...hat.com>
>>
>> -	asm volatile ("str %0"  : "=m" (ctxt->tr));
>> +	store_gdt((struct desc_ptr *)&ctxt->gdt_limit);
>> +	store_idt((struct desc_ptr *)&ctxt->idt_limit);
>> +	ctxt->tr = store_tr();
>>  
> Would'nt a store_tr(&ctxt->tr) be more homogeneous here?

Not really.  The task register is a segment number (a simple integer),
while the sidt/sgdt instructions write the cached descriptor to memory.

--
				Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/