linux-kernel - Re: [PATCH] Memory leak in tpm_ascii_bios_measurements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a781481a0707192136h601bdf0fm14a9a664a7bfa82d@mail.gmail.com>
Date:	Fri, 20 Jul 2007 10:06:13 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Reiner Sailer" <sailer@...ibm.com>,
	"Jesper Juhl" <jesper.juhl@...il.com>, kjhall@...ux.vnet.ibm.com,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Seiji Munetoh" <munetoh@...ibm.com>,
	"Reiner Sailer" <sailer@...son.ibm.com>, stefanb@...ibm.com
Subject: Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.

On 7/20/07, Yinghai Lu <yhlu.kernel@...il.com> wrote:

> out_free:
>    kfree(log->bios_event_log);
>    kfree(log);
> out:
>    return err;
>
> could kill one extra goto.

Such constructs disallow the success path from falling through
to the same "return err;" (with err = 0 for success obviously)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/