linux-kernel - Re: [RFC, Announce] Unified x86 architecture, arch/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A1EF57.2020304@didntduck.org>
Date:	Sat, 21 Jul 2007 07:34:47 -0400
From:	Brian Gerst <bgerst@...ntduck.org>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Andi Kleen <ak@...e.de>, LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...l.org>,
	Andrew Morton <akpm@...l.org>, Ingo Molnar <mingo@...e.hu>,
	Arjan van de Ven <arjan@...radead.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RFC, Announce] Unified x86 architecture, arch/x86

Thomas Gleixner wrote:
> On Sat, 2007-07-21 at 07:37 +0200, Andi Kleen wrote: 
>> On Saturday 21 July 2007 00:32, Thomas Gleixner wrote:
>>> As an initial matter, we made it painstakingly sure that the resulting
>>> .o files in a 32-bit build are bit for bit equal.
>> You got not a single line less code duplication then, so i don't really
>> see the point of this.
> 
> Really ? 
> 
> The script detected 15 identical files with a simple cmp.
> 
> It also unified another 10 by simply looking at the only line in there
> "include <the other arch/file>"
> 
> And there is more of that, when you take the time and look closely at
> the _32.[ch] _64.[ch] files which are created by the merge.

Looking at the include files, many more are near-identical in trivial
ways, such as whitespace, comments, local variable names, or guard #ifdefs.

--
				Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/