linux-kernel - Re: [PATCH] compat_ioctl requires CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707211517.15736.arnd@arndb.de>
Date:	Sat, 21 Jul 2007 15:17:14 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Sebastian Siewior <sebastian@...akpoint.cc>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] compat_ioctl requires CONFIG_BLOCK

On Saturday 21 July 2007, Christoph Hellwig wrote:
> 
> > Adding #ifdef around an #include is considered bad style. Better just
> > make loop.h compile without any conditionals. Does the below
> > patch work for you?
> 
> That patch looks good, but even better would be adding a compat_ioctl
> handler to the loop driver.  IIRC you even have an old patch for that 

No, that doesn't fly in this case. The loop driver actually has a
compat_ioctl method, but the problem is that some tools try to
call this ioctl on devices other than loop.

We could of course add a fallback handler to compat_blkdev_ioctl(),
but I'm not convinced that this is better than the IGNORE_IOCTL
helper, unless we eventually move all of fs/compat_ioctl.c into
drivers.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/