linux-kernel - Re: pata_platform: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Jul 2007 17:46:45 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Magnus Damm <magnus.damm@...il.com>, linux-kernel@...r.kernel.org,
	Paul Mundt <lethal@...ux-sh.org>, Jeff Garzik <jeff@...zik.org>
Subject: Re: pata_platform: Fix NULL pointer dereference


On Jul 20 2007 09:12, Linus Torvalds wrote:
>Ok, the *fix* looks real enough, but it seems that you have done your line 
>splitting with a word processor rather than with a source code editor:
>
>> +	return ata_host_activate(host, platform_get_irq(pdev, 0),
>> +				 ata_interrupt, pp_info ? pp_info->irq_flags
>> +				 : 0, &pata_platform_sht);
>
>Please don't do things like this. Splitting up expressions across two 
>lines just to make the line length come out "right" is silly.
>
>So do the
>
>	"pp_info ? pp_info->irq_flags : 0"
>
>expression on one line.

Or just do

	return ata_host_activate(host, platform_get_irq(pdev, 0),
	       ata_interrupt, pp_info ? pp_info->irq_flags : 0,
	       &pata_platform_sht);

for returns, it's ok.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/