linux-kernel - Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070720183733.c53b511b.akpm@linux-foundation.org>
Date:	Fri, 20 Jul 2007 18:37:33 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	Satyam Sharma <satyam.sharma@...il.com>, rdunlap@...otime.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570

On Fri, 20 Jul 2007 18:02:57 -0700 Greg KH <gregkh@...e.de> wrote:

> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -567,7 +567,11 @@ static void __init kernel_param_sysfs_se
>  	kobject_set_name(&mk->kobj, name);
>  	kobject_init(&mk->kobj);
>  	ret = kobject_add(&mk->kobj);
> -	BUG_ON(ret < 0);
> +	if (ret) {
> +		printk(KERN_ERR "module '%s' failed to be added to sysfs, "
> +			"the system will be unstable now.\n", name);
> +		return;
> +	}

It would be nice to print the value of `ret' too.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/