linux-kernel - Re: voyager_{thread,cat}.c compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f56c1ba00707220833m267491afg277a028e6c103e31@mail.gmail.com>
Date:	Sun, 22 Jul 2007 11:33:21 -0400
From:	"Cédric Augonnet" <cedric.augonnet@...il.com>
To:	"Gabriel C" <nix.or.die@...glemail.com>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: voyager_{thread,cat}.c compile warnings

Hi,

2007/7/21, Gabriel C <nix.or.die@...glemail.com>:
> Hi,
>
> I noticed this warnings on current git:
>
>
> ...
>
> arch/i386/mach-voyager/voyager_thread.c: In function 'thread':
> arch/i386/mach-voyager/voyager_thread.c:113: warning: no return statement in function returning non-void
>
> ...
>
> I think return 0; is missing on line 112 here.
>

I guess there is no use in always returning 0, simply not returning anything and
putting a void type might be cleaner, especially as this function
seems to never
return.

>
> arch/i386/mach-voyager/voyager_cat.c: In function 'voyager_cat_init':
> arch/i386/mach-voyager/voyager_cat.c:685: warning: comparison is always false due to limited range of data type
> arch/i386/mach-voyager/voyager_cat.c:755: warning: comparison is always false due to limited range of data type
>

Hum perhaps it does not like the comparision of a __u16 and an unsigned int ?

I enclose some dummy patch that should perhaps solve these issues,
could not test it as i don't have the hardware... just my 2 cents.
Don't know if casting is an
acceptable workaround though.

>
>
> Regards,
>
> Gabriel C
>

Cheers,
Cédric

View attachment "voyager.patch" of type "text/x-diff" (1439 bytes)