linux-kernel - Re: [DRIVER SUBMISSION] DRBD wants to go mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Jul 2007 18:13:52 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Satyam Sharma <satyam.sharma@...il.com>
CC:	Lars Ellenberg <lars.ellenberg@...bit.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline

Satyam Sharma wrote:
> On 7/22/07, Lars Ellenberg <lars.ellenberg@...bit.com> wrote:
>> 94 WARNING: declaring multiple variables together should be avoided
>>     int snr, enr;
>>     does this really need to become two lines?
> 
> No, if these are some unimportant temporary/automatic variables in
> some function.
> 
> Yes, if they are members of some struct (also comment them in
> this case -- in fact give full kernel-doc style comments).

Don't overdo comments.  Comments eventually get out of date and are then
dangerously misleading.  Comment API elements.  Comment on the Why if it
isn't obvious.  It shouldn't be necessary to comment on the How, because
that should be coded in an obvious way in the first place.
-- 
Stefan Richter
-=====-=-=== -=== =-==-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/