| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87abtogu6u.fsf@penguin.cs.ucla.edu> Date: Sun, 22 Jul 2007 11:38:33 -0700 From: Paul Eggert <eggert@...UCLA.EDU> To: Simon Arlott <simon@...e.lp0.eu> Cc: Matthew Wilcox <matthew@....cx>, Denis Cheng <crquan@...il.com>, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: diffutils: C labels misdetected as functions Simon Arlott <simon@...e.lp0.eu> writes: > The patch below stops diffutils treating C labels starting in column 1 as function names. That patch alone wouldn't suffice, since -p is documented as implying -F '^[[:alpha:]$_]'. If the behavior changes, we'd also have to change the documentation to match. I'm not sure the change is a good idea. It would complicate the documentation and therefore the user interface, without that much benefit. And it wouldn't suffice in general, since it would still mishandle labels followed by comments or by white space. Also, for long C functions some people might rather see a top-level (unindented) label highlighted than the function name highlighted, so they might prefer the current behavior. Anyway, to work around your problem without changing "diff", you can use "diff -u -F '^[[:alpha:]$_](|.*[^:])$'" instead of "diff -u -p". Or you can put a single space before the labels in question: they'll still stand out plenty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists