linux-kernel - Re: [PATCH] Remove unused variable 'start'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Jul 2007 23:04:24 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Charlie Shepherd <masterdriverz@...too.org>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] Remove unused variable 'start'.

On Sat, 21 Jul 2007 20:26:47 +0200 Charlie Shepherd <masterdriverz@...too.org> wrote:

> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 3cee76a..5e7daea 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -72,7 +72,6 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
>  {
>  	pgd_t *pgd;
>  	unsigned long next;
> -	unsigned long start = addr;
>  	unsigned long end = addr + size;
>  
>  	BUG_ON(addr >= end);
> @@ -84,7 +83,7 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
>  			continue;
>  		vunmap_pud_range(pgd, addr, next);
>  	} while (pgd++, addr = next, addr != end);
> -	flush_tlb_kernel_range(start, end);
> +	flush_tlb_kernel_range(addr, end);
>  }
>  
>  static void unmap_vm_area(struct vm_struct *area)

err, no.  addr has a different value here.

There's a patch in Andi's tree which fixes the compile warning.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/