linux-kernel - Re: [RFC] Kconfig fun with sparc32/sparc64 rtc drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070722063149.GQ21668@ftp.linux.org.uk>
Date:	Sun, 22 Jul 2007 07:31:49 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
	sam@...nborg.org
Subject: Re: [RFC] Kconfig fun with sparc32/sparc64 rtc drivers

On Sat, Jul 21, 2007 at 11:22:07PM -0700, David Miller wrote:
> From: Al Viro <viro@....linux.org.uk>
> Date: Sun, 22 Jul 2007 07:19:24 +0100
> 
> > We probably ought to make drivers/sbus/char/rtc.c sparc32-only,
> > then - AFAICS it simply won't be able to register misc device and that
> > will be it.  ACK?
> 
> ACK.
> 
> > > 2) all the __sparc_v9__ crap is removed from drivers/char/rtc.c
> > > 3) all the __sparc__ crap is changed to CONFIG_SPARC32 in same
> > > 4) CONFIG_RTC is not longer allows on sparc64, only sparc32 with PCI
> > 
> > Umm...  OK, that takes care of sparc64 side of things, which is probably
> > all we realistically care about.  Except that it still leaves broken sparc32
> > defconfig - we have RTC=m, SUN_MOSTEK_RTC=m and kbuild won't deal with it...
> 
> That definitely needs to be fixed and I'm willing to entertain
> any suggestion on how to deal with it.

Crude and simple way would be to add

config JS_RTC
	tristate "JavaStation RTC"
	depends on SPARC32 && PCI
	<copy help from RTC with s/will be called rtc/will be called js-rtc>

in drivers/char/Kconfig, slap plain and simple !SPARC in RTC dependencies
and put
js-rtc-y = rtc.o
obj-$(JS_RTC) += js-rtc.o
in drivers/char/Makefile

Objections?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/