linux-kernel - Re: [00/37] Clean up duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a781481a0707212338q75995340w8e0d352bce4f3f6a@mail.gmail.com>
Date:	Sun, 22 Jul 2007 12:08:06 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Jesper Juhl" <jesper.juhl@...il.com>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [00/37] Clean up duplicate includes

On 7/22/07, Satyam Sharma <satyam.sharma@...il.com> wrote:
> On 7/21/07, Jesper Juhl <jesper.juhl@...il.com> wrote:
> > [...]
> > These are the patches in this series :
>
> Ok, I've reviewed all patches in this series except:
>
> >  [PATCH][12/37] Clean up duplicate includes in drivers/net/
> >  [PATCH][28/37] Clean up duplicate includes in net/ipv4/
> >  [PATCH][32/37] Clean up duplicate includes in net/sunrpc/

And I also looked over these three after your resends.

> Anyway, the entire series was OK, just removing a #include
> line when that exact same header was already #include'd in
> the same file. [ I also wonder if this patchset ends up exposing
> some header-include-ordering problems that were previously
> hidden, actually. ]

Like you said you built an allmodconfig, everything should be OK.
[ Except for modules that didn't get included in allmodconfig because
your arch might not have supported it -- but even then, your patches
are obviously correct and will only expose issues elsewhere if we do
see any build breakage, but which isn't likely in any case. ]

So the entire series is reviewed and looks good to me :-)

Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/