linux-kernel - Re: [DRIVER SUBMISSION] DRBD wants to go mainline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070723090101.GA30305@infradead.org>
Date:	Mon, 23 Jul 2007 10:01:01 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Kyle Moffett <mrlinuxman@....com>,
	Lars Ellenberg <lars@...bit.com>, Jens Axboe <axboe@...nel.dk>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>, drbd-user@...bit.com
Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline

On Mon, Jul 23, 2007 at 11:00:38AM +0200, Sam Ravnborg wrote:
> On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote:
> > On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote:
> > > First of all, if you could break this up into chunks (even if they
> > > aren't useful individually) just to make it easier to review.
> > 
> > No, please don't do that I have no idea why people say that except for
> > drinking too much "small patches" koolaid.
> 
> It is much more preferred to have code available in the mailer than
> being forced to copy it from some big patch somewhere when you
> want to point out something.

While that's a valid point I totally agree on for small patches it just
doesn't matter for a complex driver where you need to sit down for an
hour or more to actually do a useful review.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/