linux-kernel - Re: [patch] use __asm__ and __volatile__ in asm-x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707222045.15935.vapier@gentoo.org>
Date:	Sun, 22 Jul 2007 20:45:14 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andi Kleen <ak@...e.de>, Christoph Hellwig <hch@...radead.org>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h

On Wednesday 20 June 2007, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >> asm-i386/msr.h should not be exported to userspace at all, it contains
> >> nothing but kernel-internal helpers.
> >
> > Actually rdtsc and rdtscll and potentially rdpmc which is in there can be
> > very useful in user space if you know what you're doing. Unfortunately a
> > lot of its users don't, but not having the include probably won't stop
> > them either.
>
> More likely, people will just re-implement them incorrectly.
>
> However, the rdtsc() definition in the kernel is weird (and removable, I
> think there are no more users -- I have it removed in my MSR driver
> rewrite tree which I need to get off my arse and push.)  Most users
> would expect the rdtscll() functionality with the rdtsc() name.

does that mean you'll also take care of cleaning up msr.h ?  or do i need to 
post another patch ?
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (828 bytes)