linux-kernel - Re: [PATCH] Fix fbcon - 'map_override' defined but not used warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1185194648.5046.13.camel@daplas>
Date:	Mon, 23 Jul 2007 20:44:08 +0800
From:	"Antonino A. Daplas" <adaplas@...il.com>
To:	Gabriel C <nix.or.die@...glemail.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix fbcon - 'map_override' defined but not used warning

On Mon, 2007-07-23 at 14:07 +0200, Gabriel C wrote:
> Antonino A. Daplas wrote:
> > On Sun, 2007-07-22 at 18:23 +0200, Gabriel C wrote:
> >> Hi,
> >>
> >> I got this warning on current git:
> >>
> >> ...
> >>
> >> drivers/video/console/fbcon.c:130: warning: 'map_override' defined but not used
> >>
> >> ...
> >>
> >> Signed-off-by: Gabriel Craciunescu <nix.or.die@...glemail.com>
> >>
> >> ---
> >>
> >> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> >> index decfdc8..60a14de 100644
> >> --- a/drivers/video/console/fbcon.c
> >> +++ b/drivers/video/console/fbcon.c
> >> @@ -127,7 +127,9 @@ static int last_fb_vc = MAX_NR_CONSOLES - 1;
> >>  static int fbcon_is_default = 1; 
> >>  static int fbcon_has_exited;
> >>  static int primary_device = -1;
> >> +#ifndef MODULE
> > 
> > Disrecard my other comment. This should be
> > 
> > #ifdef CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY
> 
> You really sure ? 

Yes, I realize that. I already have a patch in my tree that will fix
this properly.

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/