linux-kernel - Re: [1/2] 2.6.23-rc1: known regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1185201122.6148.60.camel@localhost.localdomain>
Date:	Mon, 23 Jul 2007 15:32:02 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Trent Piepho <xyzzy@...akeasy.org>,
	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, acpi4asus-u@...p.vs19.net,
	Gabriel C <nix.or.die@...glemail.com>,
	Corentin Chary <corentincj@...aif.net>,
	Andreas Gruenbacher <agruen@...e.de>
Subject: Re: [1/2] 2.6.23-rc1: known regressions

On Mon, 2007-07-23 at 14:36 +0100, Al Viro wrote:
> On Mon, Jul 23, 2007 at 02:12:07PM +0100, Richard Purdie wrote:
> > Fix the leak where asus-led registration fails half way through.
>  
> Frankly, I don't think that any post-factum checks are needed.  We
> should just bail out at the point of failure.  See the patch posted
> earlier...  BTW, your variant does destroy_workqueue() when no
> create_singlethreaded_workqueue() had been called.  FWIW, here's
> the patch I'm talking about:

I saw that after I'd posted mine. I don't mind which we use... 

I'm pleased the IS_ERR(object##_led.class_dev) is gone as that makes
nasty assumptions about what the LED class does internally...

Cheers,

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/