linux-kernel - Re: [PATCH] fix broken handling of port=... in NFS option parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46A4D1DE.6070702@oracle.com>
Date:	Mon, 23 Jul 2007 12:05:50 -0400
From:	Chuck Lever <chuck.lever@...cle.com>
To:	Al Viro <viro@....linux.org.uk>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix broken handling of port=... in NFS option parsing

ACK.

Al Viro wrote:
> 	Obviously broken on little-endian; fortunately, the option is
> not frequently used...
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index b34b7a7..b2a851c 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -732,7 +732,7 @@ static int nfs_parse_mount_options(char *raw,
>  				return 0;
>  			if (option < 0 || option > 65535)
>  				return 0;
> -			mnt->nfs_server.address.sin_port = htonl(option);
> +			mnt->nfs_server.address.sin_port = htons(option);
>  			break;
>  		case Opt_rsize:
>  			if (match_int(args, &mnt->rsize))

View attachment "chuck.lever.vcf" of type "text/x-vcard" (260 bytes)