linux-kernel - Re: [linux-usb-devel] 2.6.22+: BUG: sleeping function called from invalid context at /home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:524, in_atomic():1, irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070723225725.GA25741@suse.de>
Date:	Mon, 23 Jul 2007 15:57:25 -0700
From:	Greg KH <gregkh@...e.de>
To:	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oneukum@...e.de>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Kevin Lloyd <linux@...rrawireless.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	USB development list <linux-usb-devel@...ts.sourceforge.net>
Subject: Re: [linux-usb-devel] 2.6.22+: BUG: sleeping function called from
	invalid context at
	/home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:524,
	in_atomic():1, irqs_disabled():0

On Mon, Jul 23, 2007 at 04:50:50PM -0400, Alan Stern wrote:
> On Mon, 23 Jul 2007, Jeremy Fitzhardinge wrote:
> 
> > I get this when suspending.  The kernel is 2.6.22+recent git (just before -rc1).
> > 
> > usb 2-1: USB disconnect, address 3
> > BUG: sleeping function called from invalid context at /home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:524
> > in_atomic():1, irqs_disabled():0
> > 1 lock held by khubd/207:
> >  #0:  (&table_lock){--..}, at: [<f89fba38>] usb_serial_put+0x13/0x2c [usbserial]
> >  [<c0109162>] show_trace_log_lvl+0x1a/0x2f
> >  [<c0109bf8>] show_trace+0x12/0x14
> >  [<c0109c10>] dump_stack+0x16/0x18
> >  [<c01247b7>] __might_sleep+0xea/0xf1
> >  [<c02cd7a2>] usb_kill_urb+0x1a/0xc7
> >  [<f89e7203>] sierra_shutdown+0x5d/0x9c [sierra]
> >  [<f89fbb5a>] destroy_serial+0x45/0x10a [usbserial]
> >  [<c0219a2f>] kref_put+0x63/0x71
> >  [<f89fba44>] usb_serial_put+0x1f/0x2c [usbserial]
> >  [<f89fbf00>] usb_serial_disconnect+0x79/0xa6 [usbserial]
> >  [<c02d06df>] usb_unbind_interface+0x47/0x98
> >  [<c02925f2>] __device_release_driver+0x74/0x90
> >  [<c02929e0>] device_release_driver+0x30/0x47
> >  [<c0291f81>] bus_remove_device+0x73/0x82
> >  [<c0290650>] device_del+0x208/0x27e
> >  [<c02cdf2a>] usb_disable_device+0x5f/0xbc
> >  [<c02ca497>] usb_disconnect+0x95/0x12f
> >  [<c02caba8>] hub_thread+0x377/0xa57
> >  [<c013cb7f>] kthread+0x3b/0x64
> >  [<c0108d27>] kernel_thread_helper+0x7/0x10
> >  =======================
> > sierra3 ttyUSB0: Sierra USB modem (3 port) converter now disconnected from ttyUSB0
> > sierra3 ttyUSB1: Sierra USB modem (3 port) converter now disconnected from ttyUSB1
> > sierra3 ttyUSB2: Sierra USB modem (3 port) converter now disconnected from ttyUSB2
> > sierra 2-1:1.0: device disconnected
> 
> Clearly there's a bug in 
> drivers/usb/serial/usb-serial.c:usb_serial_put().  It shouldn't call 
> kref_put() while holding a spinlock.

Oliver, didn't you make this change to the usb_serial_put() function?

Do we need to audit the shutdown() callbacks in the serial drivers so
that they can not sleep?  Or just change the spinlock to a mutex?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/