linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A53B70.1010903@intel.com>
Date:	Mon, 23 Jul 2007 16:36:16 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Andy Whitcroft <apw@...dowen.org>
CC:	Andrew Morton <akpm@...l.org>, Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.08

Andy Whitcroft wrote:
> This version brings a number of new checks, and a number of bug
> fixes.  Of note:
> 
>   - warnings for multiple assignments per line
>   - warnings for multiple declarations per line
>   - checks for single statement blocks with braces
> 
> This patch includes an update for feature-removal-schedule.txt to
> better target checks.
> 
> Andy Whitcroft (12):
>       Version: 0.08
>       check for spaces between function name and open parenthesis
> 

> +# check for spaces between functions and their parentheses.
> +		if ($line =~ /($Ident)\s+\(/ &&
> +		    $1 !~ /^(?:if|for|while|switch|return|volatile)$/ &&
> +		    $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
> +			ERROR("no space between function name and open parenthesis '('\n" . $herecurr);
> +		}


this somehow seems to match something completely non-related (a function pointer 
declaration case):

ERROR: no space between function name and open parenthesis '('
#7278: FILE: drivers/net/e1000e/hw.h:434:
+       bool (*check_mng_mode)(struct e1000_hw *);

even if I put a space between ")(", it still complains.


Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/