linux-kernel - Re: drivers/hwmon/lm93.c: array overruns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707230936.58135.hjk@linutronix.de>
Date:	Mon, 23 Jul 2007 09:36:57 +0200
From:	Hans-Jürgen Koch <hjk@...utronix.de>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: drivers/hwmon/lm93.c: array overruns

Am Montag 23 Juli 2007 02:54 schrieb Adrian Bunk:
> The Coverity checker spotted the following array overruns
> in drivers/hwmon/lm93.c:
> 
> <--  snip  -->
> 
> ...
> struct lm93_data {
> ...
>         struct {
>                 u8 min;
>                 u8 max;
>         } temp_lim[3];
> ...
> };
> ...
> static void lm93_update_client_common(struct lm93_data *data,
>                                       struct i2c_client *client)
> {
> ...
>         for (i = 0; i < 4; i++) {
>                 data->temp_lim[i].min =
>                         lm93_read_byte(client, LM93_REG_TEMP_MIN(i));
>                 data->temp_lim[i].max =
>                         lm93_read_byte(client, LM93_REG_TEMP_MAX(i));
>         }
> ...
> 
> <--  snip  -->

This patch should fix it. Thanks a lot, Adrian!

----
This fixes an array overflow bug. We have 4 pairs of min/max temperature 
limits, not 3.

Signed-off-by: Hans J. Koch <hjk@...utronix.de>

--
Index: linux-2.6.23-rc/drivers/hwmon/lm93.c
===================================================================
--- linux-2.6.23-rc.orig/drivers/hwmon/lm93.c	2007-07-23 09:22:56.000000000 +0200
+++ linux-2.6.23-rc/drivers/hwmon/lm93.c	2007-07-23 09:29:37.000000000 +0200
@@ -234,7 +234,7 @@
 	struct {
 		u8 min;
 		u8 max;
-	} temp_lim[3];
+	} temp_lim[4];
 
 	/* vin1 - vin16: low and high limits */
 	struct {



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/