linux-kernel - Re: [PATCH] LinuxPPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jul 2007 10:00:13 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] LinuxPPS - definitive version

On Mon, Jul 23, 2007 at 02:35:16PM +0100, David Woodhouse wrote:
>
> s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt

Fixed.

> Please feed it to scripts/checkpatch.pl -- you can ignore all the
> warnings about lines greater than 80 characters, and the complete crap
> about "declaring multiple variables together should be avoided", but

Done. Most fixed.

> some of what it points out is valid. Including the one about 'volatile'
> -- your explanation lacked credibility. If you really need 'volatile'
> then put it at the places you actually need it; not the declaration of
> the structure. 

Can you please explain better where should I put the 'volatile'
attribute? :-o

> You've also reverted to structures which vary between 32-bit and 64-bit
> userspace, because they use 'long' and 'struct timespec', but you
> haven't provided the compat_* routines which are then necessary.

This should be not needed due new 'struct pps_ktime'.

> +typedef int pps_handle_t;              /* represents a PPS source */
> +typedef unsigned long pps_seq_t;       /* sequence number */
> +typedef struct ntp_fp ntp_fp_t;                /* NTP-compatible time stamp */
> +typedef union pps_timeu pps_timeu_t;   /* generic data type to represent time s
> tamps */
> +typedef struct pps_info pps_info_t;    
> +typedef struct pps_params pps_params_t;
> 
> Don't do this for the structures. It's dubious enough for the integer
> types.

These typedefs are into timepps.h which is an userland file (located
into Documentation/pps/) and are requested by the RFC.

Attached you can find my last patch.

Thanks again,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...dd.com
Embedded Systems                     		giometti@...ux.it
UNIX programming                     phone:     +39 349 2432127

View attachment "ntp-pps-2.6.22-bis.diff" of type "text/plain" (68286 bytes)