linux-kernel - Re: [PATCH 8/8] dm: dm-target.c Convert kmalloc + memset to kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <33136714.1185268299275.JavaMail.root@mswamui-valley.atl.sa.earthlink.net>
Date:	Tue, 24 Jul 2007 05:11:39 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>,
	linux-kernel@...r.kernel.org
Cc:	device-mapper development <dm-devel@...hat.com>
Subject: Re: [PATCH 8/8] dm: dm-target.c Convert  kmalloc + memset  to
 kzalloc



-----Original Message-----
>From: Dmitry Monakhov <dmonakhov@...nvz.org>
>Sent: Jul 24, 2007 4:59 AM
>To: linux-kernel@...r.kernel.org
>Cc: device-mapper development <dm-devel@...hat.com>
>Subject: [PATCH 8/8] dm: dm-target.c Convert  kmalloc + memset  to kzalloc
>
>Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
>---
> drivers/md/dm-target.c |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/md/dm-target.c b/drivers/md/dm-target.c
>index 477a041..835cf95 100644
>--- a/drivers/md/dm-target.c
>+++ b/drivers/md/dm-target.c
>@@ -88,12 +88,10 @@ void dm_put_target_type(struct target_type *t)
> 
> static struct tt_internal *alloc_target(struct target_type *t)
> {
>-	struct tt_internal *ti = kmalloc(sizeof(*ti), GFP_KERNEL);
>+	struct tt_internal *ti = kzalloc(sizeof(*ti), GFP_KERNEL);
> 
>-	if (ti) {
>-		memset(ti, 0, sizeof(*ti));
>+	if (ti)
> 		ti->tt = *t;
>-	}
> 
> 	return ti;
> }
>-- 
>1.5.2.2
>
>

would it not have made more sense to have submitted all those related,
single-change patches as one patch?

rday



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/