lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Jul 2007 14:52:32 +0200 From: Andreas Schwab <schwab@...e.de> To: Jeff Garzik <jeff@...zik.org> Cc: Andy Whitcroft <apw@...dowen.org>, Jens Axboe <axboe@...nel.dk>, "James E.J. Bottomley" <James.Bottomley@...elEye.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Alessandro Rubini <rubini@...ion.unipv.it>, linuxppc-dev@...abs.org, Paul Mackerras <paulus@...ba.org>, Jens Axboe <jens.axboe@...cle.com>, Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [patch 1/3] ps3: Disk Storage Driver Jeff Garzik <jeff@...zik.org> writes: > Andy Whitcroft wrote: >> Andrew Morton wrote: >> >>>> + start_sector = req->sector*priv->blocking_factor; >>>> + sectors = req->nr_sectors*priv->blocking_factor; >>> s/*/ * /. checkpatch missed this. >> >> Ok, this is something we need to decide on. Currently we only ask for >> consistent spacing on all the mathematic operators. This is mostly as >> we do see a large number of non-spaced uses in defines and the like. >> >> I am happy to expand these tests so they are always spaced on both sides >> style if that is the preference. > > That is most definitely the preference: spaces surround operators. ^binary Andreas. -- Andreas Schwab, SuSE Labs, schwab@...e.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists