linux-kernel - Re: [Lksctp-developers] _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A5F91B.50403@hp.com>
Date:	Tue, 24 Jul 2007 09:05:31 -0400
From:	Vlad Yasevich <vladislav.yasevich@...com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Adrian Bunk <bunk@...sta.de>,
	lksctp-developers@...ts.sourceforge.net,
	Gabriel C <nix.or.die@...glemail.com>,
	"Nelson, Shannon" <shannon.nelson@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Lksctp-developers] __unsafe() usage

Rusty Russell wrote:
>  
[... snip ...]

> diff -r d7af727512fd net/sctp/protocol.c
> --- a/net/sctp/protocol.c	Tue Jul 24 08:30:05 2007 +1000
> +++ b/net/sctp/protocol.c	Tue Jul 24 09:12:43 2007 +1000
> @@ -1176,7 +1176,6 @@ SCTP_STATIC __init int sctp_init(void)
>  	if (status)
>  		goto err_v6_add_protocol;
>  
> -	__unsafe(THIS_MODULE);
>  	status = 0;
>  out:
>  	return status;
> @@ -1216,6 +1215,7 @@ err_chunk_cachep:
>  	goto out;
>  }
>  
> +#if 0
>  /* Exit handler for the SCTP protocol.  */
>  SCTP_STATIC __exit void sctp_exit(void)
>  {
> @@ -1263,9 +1263,10 @@ SCTP_STATIC __exit void sctp_exit(void)
>  
>  	proto_unregister(&sctp_prot);
>  }
> +module_exit(sctp_exit);
> +#endif
>  
>  module_init(sctp_init);
> -module_exit(sctp_exit);
>  

Please don't remove module_exit point for SCTP.  Simply removing the __unsafe() call will
be sufficient.

The code has recently been cleaned up to allow safe unloading and I working on final
cleanups.  It currently works correctly with forced unloading.

Thanks

-vlad

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/