linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070724172217.GA10725@linux-sh.org>
Date:	Wed, 25 Jul 2007 02:22:17 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andy Whitcroft <apw@...dowen.org>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.08

On Tue, Jul 24, 2007 at 02:15:26AM -0700, Andrew Morton wrote:
> On Tue, 24 Jul 2007 10:06:51 +0100 Andy Whitcroft <apw@...dowen.org> wrote:
> 
> > > This is a royal pain, since it now throws an ERROR for the obviously
> > > preferable piece of code below:
> > > 
> > > if (err) {
> > >     do_something();
> > >     return -ERR;
> > > } else {
> > >     do_somthing_else();
> > > }
> > 
> > Hmmm, is that obviouly nicer than the below?  Its fully a line longer
> > for no benefit.  But ignoring that, this seems to have snuck in to
> > CodingStyle hmmm ... will see what I can do if anything to stop these
> > being picked up I guess.
> > 
> > 	if (err) {
> > 		do_something();
> > 		return -ERR;
> > 	} else
> > 		do_something_else();
> 
> The kool kids on linux-usb-devel largely ended up deciding that the second
> version looks dorky.
> 
Since when did linux-usb-devel decide stylistic nits of the rest of the
kernel? Let them do what they want in drivers/usb, I have a hard time
accepting that what someone arbitrarily decides they want to do in their
directory suddenly blanketly applies to the rest of the kernel, and
therefore warrants a CodingStyle update.

Perhaps CodingStyle can start being versioned, so people can opt out of
certain 'improvements' whenever someone has a vision, much like some
nameless licenses.

Personally I prefer the second style, and if there's a comment block,
then it makes sense to complete the tree with {}'s (the keyword here is
prefer, as it's a personal preference). checkpatch has been quite useful
for catching obviously broken things, and now it seems like it's just
overreaching. Perhaps this functionality can be split in to a lite
checkpatch for catching show-stoppers for application and then something
more akin to a CodingStyle validator for the folks interested in
arbitrarily defining convention, which they can use freely while the rest
of us try to get something useful done.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/