linux-kernel - Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070723205241.c50624ed.akpm@linux-foundation.org>
Date:	Mon, 23 Jul 2007 20:52:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fengguang Wu <wfg@...l.ustc.edu.cn>
Cc:	linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 03/10] readahead: combine
 file_ra_state.prev_index/prev_offset into prev_pos

On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <wfg@...l.ustc.edu.cn> wrote:

> -	ra->prev_index = page->index;
> +	ra->prev_pos = page->index << PAGE_CACHE_SHIFT;

bug!  The rhs will get truncated befire it gets assigned to
the lhs.  Need to cast page->index to loff_t.

I'll fix this one up.  Please review the other patches for this?

I decided to merge this ahead of that great pile of Nick's patches
(pagecache write deadlocks) and gto a number of easy-to-fix rejects as a
result.  Hopefully it all landed OK.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/