linux-kernel - [PATCH] usb-serial: fix oti6858.c segfault in termios handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 25 Jul 2007 10:21:21 +0200
From:	Thomas Viehmann <tv@...mnet.de>
To:	<linux-kernel@...r.kernel.org>
Cc:	<linux-usb-devel@...ts.sourceforge.net>
Subject: [PATCH] usb-serial: fix oti6858.c segfault in termios handling

The oti6858 usb serial driver should use 
kernel_termios_to_user_termios/
user_termios_to_kernel_termios to avoid segfaults because the kernel
uses a structure differing from that of user space with a different 
size.

Signed-off-by: Thomas Viehmann <tv@...mnet.de>
---
I'm don't know the least thing about the type casting (it is lifted
from kobil_sct.c), but I do get better success with the patch...
--- linux-2.6.23-rc1/drivers/usb/serial/oti6858.c.orig
+++ linux-2.6.23-rc1/drivers/usb/serial/oti6858.c
@@ -818,19 +818,22 @@

        switch (cmd) {
                case TCGETS:
-                       if (copy_to_user(user_arg, port->tty->termios,
-                                               sizeof(struct 
ktermios))) {
+                       if (kernel_termios_to_user_termios(
+                                            (struct ktermios __user 
*)arg,
+                                            port->tty->termios))
                                return -EFAULT;
-                       }
                        return 0;

                case TCSETS:
                case TCSETSW:                  case TCSETSF:   -      
                  if (copy_from_user(port->tty->termios, user_arg,
-                                               sizeof(struct 
ktermios))) {
+                       if 
(user_termios_to_kernel_termios(port->tty->termios,
+                                               (struct ktermios 
__user *)arg))
                                return -EFAULT;
-                       }
                        oti6858_set_termios(port, NULL);
                        return 0;

--
Thomas Viehmann, http://thomas.viehmann.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/