linux-kernel - Re: [PATCH] Fix arch/i386/kernel/nmi.c - 'unknown_nmi_panic_callback' declared 'static' but never defined warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070724183636.63844865.akpm@linux-foundation.org>
Date:	Tue, 24 Jul 2007 18:36:36 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Gabriel C <nix.or.die@...glemail.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>, Andi Kleen <ak@...e.de>
Subject: Re: [PATCH] Fix arch/i386/kernel/nmi.c -
 'unknown_nmi_panic_callback' declared 'static' but never defined warning

On Sun, 22 Jul 2007 21:20:38 +0200 Gabriel C <nix.or.die@...glemail.com> wrote:

> I get this warning when CONFIG_SYSCTL is not set :
> 
> ...
> 
> arch/i386/kernel/nmi.c:52: warning: 'unknown_nmi_panic_callback' declared 'static' but never defined
> 
> ...
> 
> Signed-off-by: Gabriel Craciunescu <nix.or.die@...glemail.com>
> 
> ---
> 
> diff --git a/arch/i386/kernel/nmi.c b/arch/i386/kernel/nmi.c
> index 03b7f55..cf11121 100644
> --- a/arch/i386/kernel/nmi.c
> +++ b/arch/i386/kernel/nmi.c
> @@ -49,8 +49,9 @@ static unsigned int nmi_hz = HZ;
>  static DEFINE_PER_CPU(short, wd_enabled);
>  
>  /* local prototypes */
> +#ifdef CONFIG_SYSCTL
>  static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu);
> -
> +#endif
>  static int endflag __initdata = 0;

guys, please take a closer look at the code which you're changing?  We can
obviously move do_nmi_callback() down to above
__trigger_all_cpu_backtrace() and then do away with this declaration
altogether.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/