linux-kernel - Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707251006.42948.bjorn.helgaas@hp.com>
Date:	Wed, 25 Jul 2007 10:06:42 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andi Kleen <andi@...stfloor.org>, Jeff Garzik <jeff@...zik.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	SÃ©bastien DuguÃ© 
	<sebastien.dugue@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

On Wednesday 25 July 2007 09:48:08 am Alan Cox wrote:
> That isn't the problem with the IR stuff. In many cases the user wants
> the port to be showing up as a serial port for SIR usage. We need a clean
> automatic SIR/FIR switching for them. It has nothing to do with whether
> the ACPI data is trustworthy or not.

If we were starting fresh, I think the best way would be for the IR
driver to claim the whole PNP device, which typically has two I/O port
ranges, like this:

  00:03 SMCf010 SMC Fast Infrared Port
    state = active
        io 0x3e8-0x3ef
        io 0x100-0x10f
        irq 3
        dma 3

There could be an ioctl or equivalent to request SIR mode, and the
IR driver could use serial8250_register_port() when entering SIR
mode and serial8250_unregister_port() when leaving.

The IR driver would be the clear owner of the entire device.  Of course,
this still only works if we get rid of the 8250 blind probe for 0x3e8
or figure out some API for the IR driver to tell the 8250 driver to get
its mitts off.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/