linux-kernel - Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707251011.35891.bjorn.helgaas@hp.com>
Date:	Wed, 25 Jul 2007 10:11:35 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Jeff Garzik" <jeff@...zik.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	"Sébastien Dugué" 
	<sebastien.dugue@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

On Wednesday 25 July 2007 09:57:47 am Yinghai Lu wrote:
> On 7/25/07, Bjorn Helgaas <bjorn.helgaas@...com> wrote:
> > On Tuesday 24 July 2007 10:27:26 pm Yinghai Lu wrote:
> > > or we can make legacy_serial.force=1 is default at this point.
> >
> > At which point?  We already do the legacy probe if there are no
> > PNP devices.  Do you mean we should also do the legacy probe if
> > there are PNP devices, but no serial devices were found?  That
> > might be reasonable to do, but wouldn't have prevented the problem
> > on Sebastien's machine, because his machine *does* have PNP UARTs.
> 
> but still could have problem. if the system does not have any uart,
> and So we can not find that in DSDT...and we add legacy again...that
> is not right.

I'm sorry, I don't understand what you're saying.

The behavior with my patch is: If we have PNPBIOS or ACPI, and it
does not describe any UARTs, we assume the box has no UARTs.  If we
don't have PNPBIOS or ACPI, we blindly probe for legacy UARTs.

What behavior are you suggesting?

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/