linux-kernel - Re: [PATCH][RFC] getting rid of stupid loop in BUG()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0707250954400.3607@woody.linux-foundation.org>
Date:	Wed, 25 Jul 2007 09:56:12 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
cc:	jeremy@...p.org, hpa@...or.com, kaos@....com.au,
	xyzzy@...akeasy.org, viro@....linux.org.uk,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH][RFC] getting rid of stupid loop in BUG()



On Tue, 24 Jul 2007, David Miller wrote:
>
> From: Jeremy Fitzhardinge <jeremy@...p.org>
> Date: Tue, 24 Jul 2007 23:24:55 -0700
> 
> > H. Peter Anvin wrote:
> > > How far back was __builtin_trap() supported?
> > 
> > I think its relatively recent, but it might be within our supported
> > compiler window.
> 
> I'm pretty sure it is.

.. and I'm pretty sure it's immaterial.

We don't just do the "ud2" instruction - we also do the file and line 
number information after it. Which means that __builtin_trap() is useless.

So we might as well keep the loop, since both are two-byte instructions 
that tell gcc that it will never continue.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/