linux-kernel - Re: [PATCH] Add in SunOS 4.1.x compatible mode for UFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 Jul 2007 22:01:33 +0100 (BST)
From:	Mark Fortescue <mark@...hpc.demon.co.uk>
To:	Evgeniy Dushistov <dushistov@...l.ru>
cc:	wli@...omorphy.com, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add in SunOS 4.1.x compatible mode for UFS

Hi Evgeniy,

On Wed, 25 Jul 2007, Evgeniy Dushistov wrote:

> Looks good.
>
> Just a few minor things:
>
> On Wed, Jul 25, 2007 at 06:27:46PM +0100, Mark Fortescue wrote:
>> Macros have been put in to alow suport for the old static table Cylinder
>> Groups
>> but this implementation does not use them yet.
>
> But why add them to patch?

Two reasons, one to remind me that more work is needed and two so I do not 
loose them before I get around to writing any code that uses them.

>
>> +	/* Sort out mod used on SunOS 4.1.3 for fs_state */
>> +	uspi->s_postblformat = fs32_to_cpu(sb, usb3->fs_postblformat);
>> +	if (((flags & UFS_ST_MASK) == UFS_ST_SUNOS) &&
>> +	    (uspi->s_postblformat != UFS_42POSTBLFMT))
>> +	{
>> +	    flags &= ~UFS_ST_MASK;
>> +	    flags |=  UFS_ST_SUN;
>> +	}
>> +
>>
>
> Documentation/CodingStyle: if () {
>

Opps. I have been looking at code too long. I normally use/prefer a 
different codding standard. This one slipped through.

>>  	switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
>> +	case UFS_ST_SUNOS:
>> +		if (fs32_to_cpu(sb, usb3->fs_postblformat == UFS_42POSTBLFMT))
>
> Really should be so?
> May be you mean:
> fs32_to_cpu(sb, usb3->fs_postblformat) == UFS_42POSTBLFMT ?
>                                     ^
>

Opps. Yes, the bracket does need moving.

>
> -- 
> /Evgeniy
>
> -
> To unsubscribe from this list: send the line "unsubscribe sparclinux" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Please find attached a patch with corrected coding stype and bracket 
location.

Regards
 	Mark Fortescue.
View attachment "SunOS4.x-UFS4.2-v2.patch" of type "TEXT/PLAIN" (14162 bytes)