linux-kernel - Re: [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known regressions with patches]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1185448275.8197.79.camel@twins>
Date:	Thu, 26 Jul 2007 13:11:15 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Lameter <clameter@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known
	regressions with patches]

On Thu, 2007-07-26 at 14:08 +0300, Pekka Enberg wrote:
> On 7/26/07, Peter Zijlstra <peterz@...radead.org> wrote:
> > --- linux-2.6.orig/mm/slub.c
> > +++ linux-2.6/mm/slub.c
> > @@ -1656,6 +1656,7 @@ static void __always_inline slab_free(st
> >         unsigned long flags;
> >
> >         local_irq_save(flags);
> > +       debug_check_no_locks_freed(object, s->size);
> 
> Although it doesn't matter much, I think this should be s->objsize. Christoph?

Ah, I think you are right, s->size includes all the padding and
redzones.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/