linux-kernel - Re: [PATCH] core_pattern: Add ability for core_pattern to parse arguments when pattern is a pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A919EB.9060102@goop.org>
Date:	Thu, 26 Jul 2007 15:02:19 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Neil Horman <nhorman@...driver.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	wwoods@...hat.com
Subject: Re: [PATCH] core_pattern: Add ability for core_pattern to parse arguments
 when pattern is a pipe

Neil Horman wrote:
> +static void free_argv_array(char **argv)
> +{
> +	int i;
> +	if (argv != NULL) {
> +		for (i = 0; argv[i] != NULL; i++)
> +			kfree(argv[i]);
> +		kfree(argv);
> +	}
> +
> +}
>   

I've helpfully already provided free_argv() in lib/argv_split.c.

> +
> +/*
> + * format_corename_argv will inspect the corename string, 	
> + * and for every option found after the binary name
> + * it will remove the option from the string, and place it
> + * in the argv array, that can then be passed to the 
> + * usermodehelper if core_pattern is a pipe
> + * Assumes that corename is declared on the stack of the caller
> + */
> +static char **format_corename_argv(char *corename)
> +{
>   

And it looks like this could be adapted to use argv_split() with a bit
of additional processing.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/