linux-kernel - Re: [PATCH] usbhid: add ASUS LCM to the blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070726152709.6daa1c96.akpm@linux-foundation.org>
Date:	Thu, 26 Jul 2007 15:27:09 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Christian Lamparter <chunkeey@....de>
Cc:	linux-kernel@...r.kernel.org,
	linux-usb-devel@...ts.sourceforge.net,
	linux-input@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH] usbhid: add ASUS LCM to the blacklist

On Tue, 24 Jul 2007 02:28:39 +0200 Christian Lamparter <chunkeey@....de> wrote:

> Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
> attached to an internal USB bus. Unfortunatly the device reports a wrong
> DeviceDescriptor and is therefore identified as a HID device...
> 
> Signed-off-by: Christian Lamparter <chunkeey@....de>
> CC: linux-input@...ey.karlin.mff.cuni.cz
> CC: linux-usb-devel@...ts.sourceforge.net
> 
> ---
> (keep the cc!)
> for those who are interested in the userspace display driver:
> https://launchpad.net/asusoled  
> 
> 
> 
> [asus-lcm-hid-blacklist.diff  text/x-diff (865B)]
> diff -up drivers/hid/usbhid/hid-quirks.c.orig drivers/hid/usbhid/hid-quirks.c
> --- a/drivers/hid/usbhid/hid-quirks.c.orig	2007-07-24 02:23:36.000000000 +0200
> +++ b/drivers/hid/usbhid/hid-quirks.c	2007-07-24 02:25:26.000000000 +0200
> @@ -63,6 +63,9 @@
>  #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY	0x030b
>  #define USB_DEVICE_ID_APPLE_IR		0x8240
>  
> +#define USB_VENDOR_ID_ASUS		0x0b05
> +#define USB_DEVICE_ID_ASUS_LCM		0x1726
> +
>  #define USB_VENDOR_ID_ATEN		0x0557
>  #define USB_DEVICE_ID_ATEN_UC100KM	0x2004
>  #define USB_DEVICE_ID_ATEN_CS124U	0x2202
> @@ -452,6 +455,8 @@ static const struct hid_blacklist {
>  	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_BARCODE_1, HID_QUIRK_SWAPPED_MIN_MAX },
>  	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_BARCODE_2, HID_QUIRK_SWAPPED_MIN_MAX },
>  
> +	{ USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM, HID_QUIRK_IGNORE},
> +
>  	{ 0, 0 }
>  };

diff -p said that the second hnk goes into the hid_blacklist[] array, but
your patch actually places it in the hid_rdesc_blacklist[] array.

I suspect what we have here is a diff against 2.6.22?  Things changed
a lot since then - please prepare patches against the latest kernel you can get
your hands on, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/