linux-kernel - Fwd: PNP: Lindent all source files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A928D2.6030702@simon.arlott.org.uk>
Date:	Fri, 27 Jul 2007 00:05:54 +0100
From:	Simon Arlott <simon@...e.lp0.eu>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
CC:	bjorn.helgaas@...com
Subject: Fwd: PNP: Lindent all source files

Does anyone ever review what Lindent does? There's a fix up patch after this 
but it missed this at the very top of the patch and the labels.

> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9dd78466c956ac4b4f38e12032dc4249ccf57ad1
> Commit:     9dd78466c956ac4b4f38e12032dc4249ccf57ad1
> Parent:     8ec3cf7d29aef773eee5bc6cd9b0fa4d3fb42480
> Author:     Bjorn Helgaas <bjorn.helgaas@...com>
> AuthorDate: Thu Jul 26 10:41:20 2007 -0700
> Committer:  Linus Torvalds <torvalds@...dy.linux-foundation.org>
> CommitDate: Thu Jul 26 11:35:20 2007 -0700
> 
>     PNP: Lindent all source files
>     
> diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c
> index dd6384b..a379a38 100644
> --- a/drivers/pnp/card.c
> +++ b/drivers/pnp/card.c
> @@ -13,26 +13,28 @@
> -					if (compare_pnp_id(dev->id, drv_id->devs[i].id)) {
> +					if (compare_pnp_id
> +					    (dev->id, drv_id->devs[i].id)) {

Leaving only the function name on a seperate line? How is that better?


> @@ -320,7 +330,7 @@ found:
>  
>  	return dev;
>  
> -err_out:
> +      err_out:
>  	dev->dev.driver = NULL;
>  	dev->card_link = NULL;
>  	return NULL;

Six spaces before a label that originally had no indentation?


The spaces it uses on lines after if (which happens all over the place) 
appear to go against CodingStyle's:
"Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation, and the above example is deliberately broken."

-- 
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/