linux-kernel - Re: [PATCH][dccp] Fix memory leak and clean up style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5640c7e00707261616x8eb332fg2406b72d2e1f1f12@mail.gmail.com>
Date:	Fri, 27 Jul 2007 11:16:28 +1200
From:	"Ian McDonald" <ian.mcdonald@...di.co.nz>
To:	"Jesper Juhl" <jesper.juhl@...il.com>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Andrea Bittau" <a.bittau@...ucl.ac.uk>,
	"Arnaldo Carvalho de Melo" <acme@...stprotocols.net>,
	dccp@...r.kernel.org
Subject: Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()

On 7/27/07, Jesper Juhl <jesper.juhl@...il.com> wrote:
>
> Greetings,
>
> There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm().
> If we hit the 'default:' case of the 'switch' statement, then we
> return without freeing 'opt', thus leaking 'struct dccp_opt_pend'
> bytes.
> The leak is fixed easily enough by adding a kfree(opt); before the
> return statement.
> The patch also changes the layout of the 'switch' to be more in line
> with CodingStyle.
>
> Patch has been compile tested.
>
> Please consider merging.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>

Signed-off-by: Ian McDonald <ian.mcdonald@...di.co.nz>
-- 
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/