linux-kernel - Re: [PATCH] make powerpc BUG_ON() OK with pointers and bitwise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Jul 2007 09:30:38 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] make powerpc BUG_ON() OK with pointers and bitwise

Al Viro writes:

> Since powerpc insists on printing the _value_ of condition

We don't _print_ the value of the condition, we give it to a
conditional-trap instruction which will trap if it is non-zero.

> and on casting it to long...  At least let's make it a force-cast.

The long cast is to make sure it's sign-extended to the full register
width.  Adding __force looks fine.

> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Acked-by: Paul Mackerras <paulus@...ba.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/