linux-kernel - Re: [PATCH 06/68] 0 -> NULL, for arch/frv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070727100004.GV27237@ftp.linux.org.uk>
Date:	Fri, 27 Jul 2007 11:00:04 +0100
From:	Al Viro <viro@....linux.org.uk>
To:	Yoann Padioleau <padator@...adoo.fr>
Cc:	kernel-janitors@...r.kernel.org, dhowells@...hat.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/68] 0 -> NULL, for arch/frv

On Fri, Jul 27, 2007 at 11:44:35AM +0200, Yoann Padioleau wrote:
>  	pte = pte_alloc_kernel(pme, va);
> -	if (pte != 0) {
> +	if (pte != NULL) {
>  		err = 0;
>  		set_pte(pte, mk_pte_phys(pa & PAGE_MASK, prot));
>  	}
> @@ -99,7 +99,7 @@ void *consistent_alloc(gfp_t gfp, size_t
>  
>  	/* allocate some common virtual space to map the new pages */
>  	area = get_vm_area(size, VM_ALLOC);
> -	if (area == 0) {
> +	if (area == NULL) {
>  		free_pages(page, order);
>  		return NULL;

Same comment about comparisons with NULL after allocation...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/