linux-kernel - Re: [PATCH] Fix regression caused by typo in lm90.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1185539063.6855.2.camel@ella.mchp.siemens.de>
Date:	Fri, 27 Jul 2007 14:24:23 +0200
From:	Rainer Birkenmaier <rainer.birkenmaier@...mens.com>
To:	Guillaume Chazarain <guichaz@...oo.fr>
Cc:	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Jean Delvare <khali@...ux-fr.org>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [PATCH] Fix regression caused by typo in lm90.c

Hi,

my original patch for this didn't have that typo, however I had spelled
it in small letters instead of capital letters. So I guess, the typo
sneaked in while switching from small to capital letter.

Main message: I can confirm that it actually is a typo :)

have a great day
/Rainer

Am Freitag, den 27.07.2007, 01:04 +0200 schrieb Guillaume Chazarain:
> Hi,
> 
> The commit http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=32c82a934759b2c9939c9e25865c2d7d1204b9e8
> broke lm90 for my (Asus V6VA) laptop.
> 
> Before 2.6.23-rc1 and with the following patch, I get:
> 
> [g ~]$ sensors
> max6657-i2c-0-4c
> Adapter: SMBus I801 adapter at 0400
> M/B Temp:    +64Â°C  (low  =    +0Â°C, high =  +127Â°C)   
> CPU Temp:  +78.9Â°C  (low  = +73.2Â°C, high = +88.2Â°C)   
> M/B Crit:   +105Â°C  (hyst =   +95Â°C)                   
> CPU Crit:   +105Â°C  (hyst =   +95Â°C)                   
> 
> Which regressed into:
> 
> [g ~]$ sensors
> No sensors found!
> Make sure you loaded all the kernel drivers you need.
> Try sensors-detect to find out which these are.
> zsh: 2701 exit 1     sensors
> 
> and dmesg contains:
> 
> i2c-adapter i2c-0: Unsupported chip (man_id=0x4D, chip_id=0x4D).
> 
> It seems to be a typo, as address 0X4F is mentionned nowhere else in the file,
> and my chip is actually at 0x4C.
> 
> Thanks.
> 
> Signed-off-by: Guillaume Chazarain <guichaz@...oo.fr>
> ---
> 
> diff -r 4cad6fced1a8 drivers/hwmon/lm90.c
> --- a/drivers/hwmon/lm90.c	Thu Jul 26 13:44:58 2007 -0700
> +++ b/drivers/hwmon/lm90.c	Tue Jul 24 00:02:52 2007 +0200
> @@ -585,7 +585,7 @@ static int lm90_detect(struct i2c_adapte
>  			 * those of the man_id register.
>  			 */
>  			if (chip_id == man_id
> -			 && (address == 0x4F || address == 0x4D)
> +			 && (address == 0x4C || address == 0x4D)
>  			 && (reg_config1 & 0x1F) == (man_id & 0x0F)
>  			 && reg_convrate <= 0x09) {
>  			 	kind = max6657;
-- 
>>> SIEMENS AG - Corporate Technology (CT SE 2)        <<<
>>> Dipl.-Inf. Rainer Birkenmaier                      <<<
>>>              email: rainer.birkenmaier@...mens.com <<<
>>>     phone: +49-89-636-53725  fax: +49-89-636-45450 <<<

Siemens Aktiengesellschaft: Vorsitzender des Aufsichtsrats: Gerhard Cromme
Vorstand: Peter Löscher, Vorsitzender; Johannes Feldmayer, Heinrich
Hiesinger, Joe Kaeser, Rudi Lamprecht, Eduardo Montes, 
Jürgen Radomski, Erich R. Reinhardt, Hermann Requardt, Uriel J. Sharef,
Klaus Wucherer
Sitz der Gesellschaft: Berlin und München; Registergericht: Berlin
Charlottenburg, HRB 12300, München, HRB 6684
WEEE-Reg.-Nr. DE 23691322

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/