linux-kernel - Re: [linux-usb-devel] usb-storage autosuspend bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0707271010320.3428-100000@iolanthe.rowland.org>
Date:	Fri, 27 Jul 2007 10:14:09 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Greg KH <gregkh@...e.de>, Oliver Neukum <oliver@...kum.org>
cc:	USB development list <linux-usb-devel@...ts.sourceforge.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [linux-usb-devel] usb-storage autosuspend bug?

On Fri, 27 Jul 2007, Oliver Neukum wrote:

> Am Donnerstag 26 Juli 2007 schrieb Greg KH:
> > Alan and Oliver, was this caused by the autosuspend changes for
> > usb-storage?
> 
> The oops itself looks like refcounting. What caused the initial io error
> does not become clear from the log. It is possible that the device cannot
> stand suspension. But there's no evidence from that. On the contrary,
> these devices usually do an unplug/plug cycle, which is not in the log.

I don't think it's a refcounting problem.  My guess is that the 
underlying cause is the bug in your urb->status removal patch for 
usb_start_wait_urb() -- the one I fixed here:

http://marc.info/?l=linux-usb-devel&m=118531582013355&w=2

Of course, my guess could be wrong.  I haven't tried to recreate 
Linus's bug with that patch reverted.  But with the patch present I was 
not able to duplicate the bug.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/