[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1185555916.2642.8.camel@josh-work.beaverton.ibm.com>
Date: Fri, 27 Jul 2007 10:05:16 -0700
From: Josh Triplett <josht@...ux.vnet.ibm.com>
To: Krzysztof Halasa <khc@...waw.pl>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-sparse@...r.kernel.org
Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces.
On Fri, 2007-07-27 at 18:00 +0200, Krzysztof Halasa wrote:
> Andrew Morton <akpm@...ux-foundation.org> writes:
>
> > it's better that we all do things the same way. What that way _is_ is
> > actually less important, unless it's something stupid, of course.
>
> It's certainly true WRT things like indentation but IMHO it shouldn't
> go that far, and if it goes, it should be non-braced version.
>
> If we prefer non-braced versions of "if" and "while", it would be
> a bit strange to require braces with "do while", wouldn't it?
Perhaps, but
1. Existing kernel style uses braces with single-statement
do-while.
2. Linus prefers (or at least preferred in October of 2006) braces
with single-statement do-while.
> Sparse warnings... I think it shouldn't complain either, unless
> called with extra parameter.
Good point; Sparse shouldn't warn about this by default. I've turned
that off in latest Sparse from Git, so you need to give -Wdo-while or
-Wall to get warnings about that. However, the kernel gives -Wall, so
you'll still see the warnings there.
- Josh Triplett
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists